Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CI System to Build for Mac x86-64 and Windows x86-64 #183

Merged
merged 4 commits into from
May 6, 2024

Conversation

IntegerLimit
Copy link
Collaborator

@IntegerLimit IntegerLimit commented Apr 30, 2024

This PR expands on the base CI System implemented in #148, #174, and #175. This PR adds the compilation and architecture test for both Windows x86-64 and Mac x86-64. As Github Actions has not yet added support for Windows ARM, that is not included in this PR. The file has also been renamed to a more descriptive name (build.yaml vs ci.yaml)

This serves two functions:

  1. As a rough guide for other users compiling on those systems
  2. As a stepping stone for more robust CI/CD in the future, incorporating builds for all architectures, and those compiled files being uploaded as Action Artefacts, or as Release Binaries.

I have also made the CI System cancel if a second commit is pushed before the task finishes, which is especially important here given the long compile time of Linux ARM (~46 Minutes).

@iqtree
Copy link
Collaborator

iqtree commented May 1, 2024

The patch looks very good, thanks! However, can you rename the file back to ci.yaml? (I think that is the standard for continuous integration thing).

@bqminh
Copy link
Member

bqminh commented May 3, 2024

Build for Windows failed... pls have a look

@IntegerLimit
Copy link
Collaborator Author

Yep, Taking a Look Now.

Action does not include proper tags to be able to use major version specification.
@IntegerLimit
Copy link
Collaborator Author

Build for Windows failed... pls have a look

Fixed in above commit 👍

@bqminh bqminh merged commit c665a53 into iqtree:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants