Add support for external custom dispatch rewrite patterns #15235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qedawkins
force-pushed
the
custom_matching_pass
branch
from
5d9d65c to
7e5f809
Compare
benvanik
requested changes
Oct 19, 2023
compiler/src/iree/compiler/Dialect/HAL/Utils/ExternBuildingUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/HAL/Utils/ExternBuildingUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/HAL/Utils/ExternBuildingUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/HAL/Utils/ExternBuildingUtils.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/HAL/Utils/ExternBuildingUtils.cpp
Outdated
Show resolved
Hide resolved
qedawkins
force-pushed
the
custom_matching_pass
branch
from
bb370ac to
afc2a24
Compare
qedawkins
commented
Oct 27, 2023
| } | ||
|
|
||
| module { | ||
| pdl.pattern : benefit(1) { |
There was a problem hiding this comment.
@stellaraccident with nod-ai/SHARK-ModelDev#108, I wanted to ask whether this still looks like a good path to go down. Essentially the idea was to allow users to specify patterns to match and replace a (flat) DAG with some custom dispatch call by specifying PDL patterns, but I'm thinking there are probably more user friendly ways to do it.
Currently custom dispatches must be written in as a part of downstream flows (targeting `hal.dispatch.extern` or Flow ops directly). This limits how lightweight deployment of custom dispatches with nearly stock IREE flows. This adds a mechanism to plugin and apply pdl patterns completely separate from other IR. This allows hermetically sealing the details of a custom dispatch as a separate IR module that is easy to reuse across models. The intent is to follow up to this patch with similar passes in the various input dialects to allow different potential rewrite points, as well as turn some of the rewriting utilities into transform operations as another way to represent the dispatch + rewrite logic without the need for C++ and a downstream project.
qedawkins
force-pushed
the
custom_matching_pass
branch
from
83476ee to
1eb5abf
Compare
|
Closing as this is superseded by #16150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently custom dispatches must be written in as a part of downstream flows (targeting
hal.dispatch.externor Flow ops directly). This limits how lightweight deployment of custom dispatches with nearly stock IREE flows. This adds a mechanism to plugin and apply pdl patterns completely separate from other IR. This allows hermetically sealing the details of a custom dispatch as a separate IR module that is easy to reuse across models.The intent is to follow up to this patch with similar passes in the various input dialects to allow different potential rewrite points, as well as turn some of the rewriting utilities into transform operations as another way to represent the dispatch + rewrite logic without the need for C++ and a downstram project.