Do not set CMAKE_CXX_STANDARD as CACHE #20261
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Letu Ren <fantasquex@gmail.com>
FantasqueX
force-pushed
the
do-not-set-cxx-std-cache
branch
from
67d0b92 to
8d1f758
Compare
ScottTodd
reviewed
Mar 25, 2025
Co-authored-by: Scott Todd <scott.todd0@gmail.com>
|
Enough CI checks passed for this to be merged. I also set the DCO check to passing since the first commit had the sign off and the second commit was a recommended edit (which github doesn't add signed-off-by to >_>) |
ScottTodd
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM will unset
CMAKE_CXX_STANDARD. We can do the same thing.LLVM Ref: https://github.com/llvm/llvm-project/blob/c8b8415b1af12d2a67b523ed3d005d296fb97144/llvm/CMakeLists.txt#L65-L70