[DispatchCreation] Add support for hoisting Flow ops. #20346
+69
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
previously approved these changes
Mar 21, 2025
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
hoist-flow-tensor-encode
branch
from
9640357 to
5cd8ce5
Compare
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
commented
Mar 21, 2025
compiler/src/iree/compiler/Dialect/Util/Analysis/Constant/ConstExpr.cpp
Outdated
Show resolved
Hide resolved
hanhanW
dismissed
MaheshRavishankar’s stale review
Remove the approval because there is a new issue in custom_dispatch.
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
changed the title
hanhanW
commented
Mar 24, 2025
Comment on lines
+505
to
+506
| UnhoistableOpInterfaceHelper< | ||
| IREE::Flow::DispatchWorkgroupCountOp>::registerOpInterface(context); |
There was a problem hiding this comment.
It turns out that I just need to add the op to unhoistable list, which makes sense to me.
|
@MaheshRavishankar can I get a review from you? I dismissed the approval because I thought there are more things to do. It turns out that I just need to add the workgroup count op to unhoistable list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision enables the hoisting of constants and weights for data-tiling. It also fixes a bug in hoisting the constants.
The DispatchWorkgroupCountOp is marked as unhoistable. It happens in custom_dispatch, which is not on regular path, so new tests are not added.