-
Notifications
You must be signed in to change notification settings - Fork 25
[debugging] emit new iree flag for debugging #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds debugging support for Wave kernels by emitting DWARF debug information through a new IREE flag. It enables developers to debug compiled Wave kernels with proper source location mapping.
- Adds conditional emission of
--iree-hip-emit-debug-infoflag based on debug configuration - Introduces comprehensive end-to-end test for DWARF debug information in compiled Wave kernels
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wave_lang/kernel/wave/utils/compile_utils.py | Adds conditional IREE debug flag emission when debug info is not dropped |
| lit_tests/kernel/wave/debug_dwarf.py | New test verifying DWARF debug information preservation through compilation pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b78c04b to
20b0681
Compare
20b0681 to
329a335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
329a335 to
09a0ef2
Compare
Depends on iree-org/iree#22216 in iree. Along with #340 this enables DWARF output with locations for Wave kernels. Signed-off-by: William G Hatch <william@hatch.uno>
Signed-off-by: William G Hatch <william@hatch.uno>
09a0ef2 to
792ea44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: William G Hatch <william@hatch.uno>
Depends on iree-org/iree#22216 in iree.
Along with #340 this enables DWARF output with locations for Wave kernels.