This repository has been archived by the owner on May 3, 2024. It is now read-only.
Wildcard analyzer helpers #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBkkt
force-pushed
the
wildcard-analyzer
branch
from
338f5c7 to
df94567
Compare
Dronplane
suggested changes
Nov 30, 2023
|
|
||
| return false; | ||
| std::shared_ptr<velocypack::Builder> ParseArgs(std::string_view args) try { |
There was a problem hiding this comment.
and BTW why hide possible velocypack exception?
| input = input.get(kNumHashes); | ||
| if (!input.isNumber<uint32_t>()) { | ||
| IRS_LOG_ERROR( | ||
| absl::StrCat(kNumHashes, " attribute must be uint32_t", kParseError)); |
There was a problem hiding this comment.
Suggested change
| absl::StrCat(kNumHashes, " attribute must be uint32_t", kParseError)); | |
| absl::StrCat(kNumHashes, " attribute must be a positive number", kParseError)); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.