This repository has been archived by the owner on May 3, 2024. It is now read-only.
downgrade "expected" warning message to info message #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there is an attempt to insert data into the columns cache, there is currently no check if the columns cache actually has a size > 0. if the columns cache is configured with a size of 0, then all insert attempts will fail and produce the warning "Failed to allocate memory for buffered column id x, name: x of size x" the warning on its own looks scary, but it is totally expected in case the columns cache is configured with a size of 0 (which is the default value in ArangoDB). this PR changes the message text so it is more clear what could have caused the problem, and also downgrades the log level from WARN to INFO. the message text is now extended with the following text: "This can happen if no columns cache was configured or the column data exceeds the columns cache size."
MBkkt
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there is an attempt to insert data into the columns cache, there is currently no check if the columns cache actually has a size > 0. if the columns cache is configured with a size of 0, then all insert attempts will fail and produce the warning
"Failed to allocate memory for buffered column id x, name: x of size x"
the warning on its own looks scary, but it is totally expected in case the columns cache is configured with a size of 0 (which is the default value in ArangoDB).
this PR changes the message text so it is more clear what could have caused the problem, and also downgrades the log level from WARN to INFO.
the message text is now extended with the following text:
"This can happen if no columns cache was configured or the column data exceeds the columns cache size."