Document set comprehension lowering and backend wire representation#224
Open
gordonwatts wants to merge 1 commit intomasterfrom
Open
Document set comprehension lowering and backend wire representation#224gordonwatts wants to merge 1 commit intomasterfrom
gordonwatts wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
func_adlwire so backends can rely on a stable, backend-agnostic representation.Description
func_adl/ast/syntatic_sugar.pyviavisit_SetComp, which inlines literal iterables toast.Set, emitsset()for empty results, and raisesValueError(includingast.unparse(node)) for non-literal iterables.tests/ast/test_syntatic_sugar.pyverifying literal set lowering, empty-literal lowering toset(), and error behavior for non-literal iterables.README.mdanddocs/source/generic/query_structure.mdto document the syntactic-sugar behavior for set comprehensions and to describe what AST form (ast.Setorset()call) is sent to the backend when.value()is called.Testing
pytest tests/ast/test_syntatic_sugar.pyand all tests passed (45 passed).black --check func_adl testsand it completed with no formatting changes required.flake8 func_adl testswith no linting issues reported.Codex Task