add eslint and enforce styles with react/typescript#24
Open
gregoryguillou wants to merge 1 commit intoirisdv:mainfrom
Open
add eslint and enforce styles with react/typescript#24gregoryguillou wants to merge 1 commit intoirisdv:mainfrom
gregoryguillou wants to merge 1 commit intoirisdv:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gregoryguillou
force-pushed
the
fix/enforce-styles
branch
from
0eed1de to
c938598
Compare
irisdv
approved these changes
Sep 1, 2022
gregoryguillou
force-pushed
the
fix/enforce-styles
branch
from
c938598 to
8708c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2 files that are changed are actually
package.json,.eslintrc.js,.prettierignoreand.prettierrc.json. You improve the files withnpm run lintand `npm run prettier".I had to change line 810 of
src/client/components/GameUI/BuildingFrame.tsx(after the lint/prettier) because it saysrechargesare not part of a typenever. Maybe there is a missing cast/declaration. Anyway this might actually be a real error or more likely a type error.I have remove all the changes and rebased on main. This way the PR is simpler.