Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[521] clearer documentation and errors regarding pam/pam_password #524

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[521] clearer documentation and errors regarding pam/pam_password #524

merged 1 commit into from
Apr 26, 2024

Conversation

d-w-moore
Copy link
Collaborator

@d-w-moore d-w-moore commented Mar 27, 2024 •
edited
Loading

Basically we're changing the README here to add background about "pam" vs. "pam_password" scheme strings, and altering the error message to be more user-friendly and cogent when attempting to use an "irods_authentication_scheme" setting of "pam" under iRODS 4.3+

alanking
alanking reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a suggestion and a question

README.md Outdated Show resolved Hide resolved
irods/auth/pam.py Outdated Show resolved Hide resolved
korydraughn
korydraughn reviewed Mar 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@trel trel changed the title clearer documentation and errors regarding pam/pam_password [521] clearer documentation and errors regarding pam/pam_password Apr 25, 2024
@d-w-moore
Copy link
Collaborator Author

Should be pretty much ready to ship now....

korydraughn
korydraughn reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording looks good to me.

korydraughn
korydraughn approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get one more approval.

trel
trel reviewed Apr 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
alanking
alanking approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, # it

trel
trel reviewed Apr 26, 2024
View reviewed changes
README.md Show resolved Hide resolved
@d-w-moore
[irods#521] clearer documentation and errors regarding pam/pam_password
390a442 
Also incorporated is the pass-through module pam.py which incorporates
a version check and reminds users in a friendly way (ie. by throwing a
fatal exception with a non-confusing message :) ) to update their
PAM scheme strings for 4.3+ ...
@d-w-moore
Copy link
Collaborator Author

Yep, # it

Done

@d-w-moore d-w-moore mentioned this pull request Apr 26, 2024
Open
@alanking alanking merged commit 9206646 into irods:main Apr 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking approved these changes

@trel trel trel left review comments

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-w-moore @trel @korydraughn @alanking