Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#537] add --help option #599

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[#537] add --help option #599

merged 1 commit into from
Aug 1, 2024

Conversation

d-w-moore
Copy link
Collaborator

@d-w-moore d-w-moore commented Aug 1, 2024 •
edited
Loading

--help option added to setupssl.py script, as -h was already taken.
See #537 (comment)

korydraughn
korydraughn reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Just one comment.

irods/test/setupssl.py Outdated Show resolved Hide resolved
alanking
alanking reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash em

alanking
alanking approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention setupssl.py in the commit message. Please add #s

@alanking alanking merged commit cf2cb7f into irods:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn left review comments

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-w-moore @korydraughn @alanking