Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#635] client_init free functions can now suppress overwriting old .irodsA #663

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[#635] client_init free functions can now suppress overwriting old .irodsA #663

merged 3 commits into from
Dec 11, 2024

Conversation

d-w-moore
Copy link
Collaborator

A new parameter named "overwrite", determines whether an old file will be overwritten, and defaults to True.

Also: we add a helper function _open_for_protected_content, a context manager which encapsulates the opening for write, writing, and closing of a file with protected content (ie only readable by the owner, using a umask of 077 octal by default).

trel
trel reviewed Dec 7, 2024
View reviewed changes
irods/client_init.py Outdated Show resolved Hide resolved
trel
trel reviewed Dec 7, 2024
View reviewed changes
irods/client_init.py Outdated Show resolved Hide resolved
trel
trel reviewed Dec 7, 2024
View reviewed changes
irods/client_init.py Outdated Show resolved Hide resolved
trel
trel reviewed Dec 7, 2024
View reviewed changes
irods/client_init.py Outdated Show resolved Hide resolved
alanking
alanking reviewed Dec 9, 2024
View reviewed changes
irods/client_init.py Outdated Show resolved Hide resolved
@d-w-moore d-w-moore force-pushed the 635.m branch 3 times, most recently from 40e3e20 to 98c8e9f Compare December 11, 2024 14:17
alanking
alanking reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one point of confusion around a comment. Otherwise, seems like this is close to ready

irods/test/scripts/test002_write_native_credentials_to_secrets_file.bats Outdated Show resolved Hide resolved
korydraughn
korydraughn reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Are the tests passing?

@d-w-moore
Copy link
Collaborator Author

Looks good to me.

Are the tests passing?

Yes!

alanking
alanking reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready for squashing given that the review comments are all resolved and the tests are passing.

@korydraughn
Copy link
Contributor

Squash it!

@d-w-moore d-w-moore force-pushed the 635.m branch 2 times, most recently from e4a38d0 to 53e80c9 Compare December 11, 2024 18:49
@d-w-moore
Copy link
Collaborator Author

Squashed; changed reference to test003 test script in commit message to be more descriptive.

alanking
alanking approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's # it

@d-w-moore
Copy link
Collaborator Author

#'d

@alanking
Copy link
Contributor

Just noticed that the commit linking to #517 should be updated to reference a new issue for the 3.0.0 milestone. The issue is closed and exists in a closed milestone. So, please open a new issue for the problem being addressed in "pam_password irodsA and login test corrected for iRODS 4.2" and link that instead. Thanks

@d-w-moore
Copy link
Collaborator Author

Just noticed that the commit linking to #517 should be updated to reference a new issue for the 3.0.0 milestone. The issue is closed and exists in a closed milestone. So, please open a new issue for the problem being addressed in "pam_password irodsA and login test corrected for iRODS 4.2" and link that instead. Thanks

Ok ... this is now done.

@alanking
Copy link
Contributor

Thanks!

@alanking alanking merged commit ba7d25e into irods:main Dec 11, 2024
1 check failed
@alanking alanking mentioned this pull request Dec 12, 2024
Merged
@d-w-moore d-w-moore deleted the 635.m branch January 19, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trel trel trel left review comments

@alanking alanking alanking approved these changes

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-w-moore @korydraughn @alanking @trel