Skip to content

[DW-29] stop using CloneAs in GetPixelColor#124

Merged
first-ironsoftware merged 1 commit intodevelopfrom
DW-29-GetPixel-OutOfMemoryException
Feb 20, 2025
Merged

[DW-29] stop using CloneAs in GetPixelColor#124
first-ironsoftware merged 1 commit intodevelopfrom
DW-29-GetPixel-OutOfMemoryException

Conversation

@ikkyuland
Copy link
Copy Markdown
Member

@ikkyuland ikkyuland commented Feb 20, 2025

Title

Fix Out of memory exception when call GetPixel

Description

  • Stop using CloneAs in GetPixelColor (its create a whole new image in memory)

Fixes
DW-29

Type of change

Please select the relevant option by placing an 'x' inside the brackets, like this: [x].

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Internal/structural update (non-breaking change that improves code quality, organization, or performance)
  • 📚 This change requires a documentation update
  • 🚀 DevOps build chain modification for release
  • 🤖 DevOps build chain modification for CI

How Has This Been Tested?

Added unit tests

Checklist:

Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully run all unit tests on Windows
  • I have successfully run all unit tests on Linux

Additional Context

Add any other context, screenshots, or information about the pull request here.

Copy link
Copy Markdown
Member

@mee-ironsoftware mee-ironsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @ikkyuland

@first-ironsoftware first-ironsoftware merged commit 4d4f8f2 into develop Feb 20, 2025
9 checks passed
@first-ironsoftware first-ironsoftware deleted the DW-29-GetPixel-OutOfMemoryException branch February 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants