[DW-26] Fix incorrect horizontal resolution and vertical resolution of AnyBitmap images#129
Merged
first-ironsoftware merged 4 commits intodevelopfrom Feb 24, 2025
Conversation
kannapat-ironsoftware
approved these changes
Feb 21, 2025
Member
kannapat-ironsoftware
left a comment
There was a problem hiding this comment.
Nice find !!
Should we combine unit tests into a single unit test with 2 assertions ?
So, we don't have to load test images and run iterations twice.
ikkyuland
approved these changes
Feb 21, 2025
Contributor
Author
Thank you for your suggestion @kannapat-ironsoftware I will do it accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect horizontal resolution and vertical resolution of AnyBitmap images
Description
Provide a brief description of the changes made in this PR. Explain what the PR does, what issue it resolves, or what feature it adds.
Fixes #DW-26
Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Check the resolutions of images after it's loaded as AnyBitmap and compare it with the expected numbers from the metadata from the images.
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].
Additional Context
Add any other context, screenshots, or information about the pull request here.