Skip to content

[DW-26] Fix incorrect horizontal resolution and vertical resolution of AnyBitmap images#129

Merged
first-ironsoftware merged 4 commits intodevelopfrom
DW-26-fix-incorrect-HorizontalResolution-and-VerticalResuolution-of-AnyBitmap-images
Feb 24, 2025
Merged

[DW-26] Fix incorrect horizontal resolution and vertical resolution of AnyBitmap images#129
first-ironsoftware merged 4 commits intodevelopfrom
DW-26-fix-incorrect-HorizontalResolution-and-VerticalResuolution-of-AnyBitmap-images

Conversation

@first-ironsoftware
Copy link
Copy Markdown
Contributor

@first-ironsoftware first-ironsoftware commented Feb 21, 2025

Fix incorrect horizontal resolution and vertical resolution of AnyBitmap images

Description

Provide a brief description of the changes made in this PR. Explain what the PR does, what issue it resolves, or what feature it adds.

Fixes #DW-26

Type of change

Please select the relevant option by placing an 'x' inside the brackets, like this: [x].

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Internal/structural update (non-breaking change that improves code quality, organization, or performance)
  • 📚 This change requires a documentation update
  • 🚀 DevOps build chain modification for release
  • 🤖 DevOps build chain modification for CI

How Has This Been Tested?

Check the resolutions of images after it's loaded as AnyBitmap and compare it with the expected numbers from the metadata from the images.

Checklist:

Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully run all unit tests on Windows
  • I have successfully run all unit tests on Linux

Additional Context

Add any other context, screenshots, or information about the pull request here.

Copy link
Copy Markdown
Member

@kannapat-ironsoftware kannapat-ironsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find !!
Should we combine unit tests into a single unit test with 2 assertions ?
So, we don't have to load test images and run iterations twice.

@first-ironsoftware
Copy link
Copy Markdown
Contributor Author

Nice find !! Should we combine unit tests into a single unit test with 2 assertions ? So, we don't have to load test images and run iterations twice.

Thank you for your suggestion @kannapat-ironsoftware I will do it accordingly.

@first-ironsoftware first-ironsoftware merged commit 37cd3d8 into develop Feb 24, 2025
9 checks passed
@first-ironsoftware first-ironsoftware deleted the DW-26-fix-incorrect-HorizontalResolution-and-VerticalResuolution-of-AnyBitmap-images branch February 24, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants