[DW-34] lazy load AnyBitmap & improve Tiff processing#136
Merged
first-ironsoftware merged 27 commits intodevelopfrom Aug 19, 2025
Merged
[DW-34] lazy load AnyBitmap & improve Tiff processing#136first-ironsoftware merged 27 commits intodevelopfrom
first-ironsoftware merged 27 commits intodevelopfrom
Conversation
mee-ironsoftware
requested changes
Aug 7, 2025
Member
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Please check my feedback.
IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/UnitTests/AnyBitmapFunctionality.cs
Outdated
Show resolved
Hide resolved
Member
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Another feedback for optimization loading Tiff image.
mee-ironsoftware
approved these changes
Aug 11, 2025
Member
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Outstanding work! The implementations significantly improve IronSoftware.System.Drawing's performance, thread safety, and maintainability.
I have 2 minor suggestions below that are optional enhancements - you can safely ignore them and proceed with merge:
- Exception Types: Consider InvalidOperationException instead of generic Exception
- FrameCount Readability: Current pattern is clever, alternative shown if preferred
mee-ironsoftware
requested changes
Aug 15, 2025
Member
mee-ironsoftware
left a comment
There was a problem hiding this comment.
@ikkyuland I just found 1 issue please check my feedback.
mee-ironsoftware
approved these changes
Aug 15, 2025
first-ironsoftware
approved these changes
Aug 19, 2025
Contributor
first-ironsoftware
left a comment
There was a problem hiding this comment.
This is great 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
DW-34 lazy load AnyBitmap & improve Tiff processing
Description
Use PNG encoder to load image that bigger than 1902 * 1080 (dynamic in .net 6) //slower than BMP which use a lot more memoryFixes #(DW-34)
From This test

Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions so others can reproduce the tests. Also, list any relevant details for your test configuration.
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].
Additional Context
Add any other context, screenshots, or information about the pull request here.