Skip to content

DW-35: Align Color FromName with System.Drawing #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mee-ironsoftware merged 2 commits into from
Aug 18, 2025
Merged

DW-35: Align Color FromName with System.Drawing #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8138e4e
DW-35: Align Color FromName with System.Drawing
Sawraz-IS Aug 6, 2025
85c2ec5
DW-35: Fix IsKnownColor Issue
Sawraz-IS Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ ipch/
# Visual Studio Trace Files
*.e2e

# JetBrains IDE settings (e.g., IntelliJ, Rider, PyCharm)
.idea/


# TFS 2012 Local Workspace
$tf/

Expand Down
44 changes: 43 additions & 1 deletion IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/UnitTests/ColorFunctionality.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,21 @@ public void Create_new_Color()
Assert.Equal(25, color.R);
Assert.Equal(25, color.G);
Assert.Equal(25, color.B);
Assert.False(color.IsKnownColor);

color = new Color("#800080");
Assert.Equal(255, color.A);
Assert.Equal(128, color.R);
Assert.Equal(0, color.G);
Assert.Equal(128, color.B);
Assert.False(color.IsKnownColor);

color = new Color("#F0F");
Assert.Equal(255, color.A);
Assert.Equal(255, color.R);
Assert.Equal(0, color.G);
Assert.Equal(255, color.B);
Assert.False(color.IsKnownColor);

InvalidOperationException ex = Assert.Throws<InvalidOperationException>(() => color = new Color("#F"));
Assert.Equal($"#F is unable to convert to {typeof(Color)} because it requires a suitable length of string.", ex.Message);
Expand All @@ -40,12 +43,14 @@ public void Create_new_Color()
Assert.Equal(255, color.R);
Assert.Equal(0, color.G);
Assert.Equal(255, color.B);
Assert.False(color.IsKnownColor);

color = new Color(255, 0, 255);
Assert.Equal(255, color.A);
Assert.Equal(255, color.R);
Assert.Equal(0, color.G);
Assert.Equal(255, color.B);
Assert.False(color.IsKnownColor);
}

[FactWithAutomaticDisplayName]
Expand All @@ -55,21 +60,25 @@ public void Create_correct_color_from_system_defined()
Assert.Equal(154, Color.YellowGreen.R);
Assert.Equal(205, Color.YellowGreen.G);
Assert.Equal(50, Color.YellowGreen.B);
Assert.True(Color.YellowGreen.IsKnownColor);

Assert.Equal(255, Color.Violet.A);
Assert.Equal(238, Color.Violet.R);
Assert.Equal(130, Color.Violet.G);
Assert.Equal(238, Color.Violet.B);
Assert.True(Color.Violet.IsKnownColor);

Assert.Equal(0, Color.Transparent.A);
Assert.Equal(255, Color.Transparent.R);
Assert.Equal(255, Color.Transparent.G);
Assert.Equal(255, Color.Transparent.B);
Assert.True(Color.Transparent.IsKnownColor);

Assert.Equal(255, Color.Azure.A);
Assert.Equal(240, Color.Azure.R);
Assert.Equal(255, Color.Azure.G);
Assert.Equal(255, Color.Azure.B);
Assert.True(Color.Azure.IsKnownColor);
}

[FactWithAutomaticDisplayName]
Expand All @@ -82,6 +91,7 @@ public void Create_color_from_RGB()
Assert.Equal(244, color.G);
Assert.Equal(208, color.B);
Assert.Equal("#FF40F4D0", color.ToString());
Assert.False(color.IsKnownColor);

color = Color.FromArgb(0, 64, 244, 208);

Expand All @@ -90,7 +100,7 @@ public void Create_color_from_RGB()
Assert.Equal(244, color.G);
Assert.Equal(208, color.B);
Assert.Equal("#0040F4D0", color.ToString());

Assert.False(color.IsKnownColor);
}

[FactWithAutomaticDisplayName]
Expand All @@ -103,25 +113,30 @@ public void Create_color_from_ARGB()
Assert.Equal(244, color.G);
Assert.Equal(208, color.B);
Assert.Equal("#6440F4D0", color.ToString());
Assert.False(color.IsKnownColor);

var color1 = Color.FromArgb(50, color);
Assert.Equal(50, color1.A);
Assert.Equal(64, color1.R);
Assert.Equal(244, color1.G);
Assert.Equal(208, color1.B);
Assert.False(color.IsKnownColor);
}

[FactWithAutomaticDisplayName]
public void Get_Luminance_from_color()
{
Color color = Color.Black;
Assert.Equal(0, color.GetLuminance());
Assert.True(color.IsKnownColor);

color = Color.Gray;
Assert.Equal(50, color.GetLuminance());
Assert.True(color.IsKnownColor);

color = Color.White;
Assert.Equal(100, color.GetLuminance());
Assert.True(color.IsKnownColor);
}

[FactWithAutomaticDisplayName]
Expand All @@ -133,20 +148,23 @@ public void Cast_System_Drawing_Color_from_Color()
Assert.Equal(255, red.R);
Assert.Equal(0, red.G);
Assert.Equal(0, red.B);
Assert.False(red.IsKnownColor);

drawingColor = System.Drawing.Color.FromArgb(255, 0, 255, 0);
Color green = drawingColor;
Assert.Equal(255, green.A);
Assert.Equal(0, green.R);
Assert.Equal(255, green.G);
Assert.Equal(0, green.B);
Assert.False(green.IsKnownColor);

drawingColor = System.Drawing.Color.FromArgb(0, 0, 255);
Color blue = drawingColor;
Assert.Equal(255, blue.A);
Assert.Equal(0, blue.R);
Assert.Equal(0, blue.G);
Assert.Equal(255, blue.B);
Assert.False(blue.IsKnownColor);

int iColorCode = Convert.ToInt32("1e81b0", 16);
drawingColor = System.Drawing.Color.FromArgb(iColorCode);
Expand All @@ -155,6 +173,7 @@ public void Cast_System_Drawing_Color_from_Color()
Assert.Equal(30, color.R);
Assert.Equal(129, color.G);
Assert.Equal(176, color.B);
Assert.False(color.IsKnownColor);
}

[FactWithAutomaticDisplayName]
Expand Down Expand Up @@ -525,46 +544,69 @@ public void Should_Create_FromName()
_ = color.R.Should().Be(255);
_ = color.G.Should().Be(0);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("green");
_ = color.R.Should().Be(0);
_ = color.G.Should().Be(128);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("blue");
_ = color.R.Should().Be(0);
_ = color.G.Should().Be(0);
_ = color.B.Should().Be(255);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("yellow");
_ = color.R.Should().Be(255);
_ = color.G.Should().Be(255);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("pink");
_ = color.R.Should().Be(255);
_ = color.G.Should().Be(192);
_ = color.B.Should().Be(203);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("brown");
_ = color.R.Should().Be(165);
_ = color.G.Should().Be(42);
_ = color.B.Should().Be(42);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("gray");
_ = color.R.Should().Be(128);
_ = color.G.Should().Be(128);
_ = color.B.Should().Be(128);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("black");
_ = color.R.Should().Be(0);
_ = color.G.Should().Be(0);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("orange");
_ = color.R.Should().Be(255);
_ = color.G.Should().Be(165);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("RebeccaPurple");
_ = color.A.Should().Be(255);
_ = color.R.Should().Be(102);
_ = color.G.Should().Be(51);
_ = color.B.Should().Be(153);
_ = color.IsKnownColor.Should().BeTrue();

color = Color.FromName("NotAColor");
_ = color.A.Should().Be(0);
_ = color.R.Should().Be(0);
_ = color.G.Should().Be(0);
_ = color.B.Should().Be(0);
_ = color.IsKnownColor.Should().BeFalse();
}

[FactWithAutomaticDisplayName]
Expand Down
Loading