Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use log.Fatal() #116

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Do not use log.Fatal() #116

merged 4 commits into from
Apr 8, 2024

Commits on Mar 28, 2024

  1. Do not use log.Fatal() 

    Return error when the k8s client cannot be initalized. Setup procedure
failure will exit the DHCP service anyway, do not use `log.Fatal()`
    @damyan
    damyan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    75f7124 View commit details
    Browse the repository at this point in the history

  2. Remove log.Fatal() leftover

    @damyan
    damyan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6e0decd View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Bring back error context when initializing k8s client

    @damyan
    damyan committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0cfcf71 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Fix review findings

    @damyan
    damyan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c946022 View commit details
    Browse the repository at this point in the history