Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt httpboot plugin to respond with client specific UKIs #155

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Adapt httpboot plugin to respond with client specific UKIs #155

merged 4 commits into from
Jun 17, 2024

Conversation

hardikdr
Copy link
Member

@hardikdr hardikdr commented Jun 6, 2024 •
edited
Loading

Proposed Changes

# For static behavior, same UKI for all requests:
- httpboot: <StaticURL>

# For dynamic behavior with bootservice:
- httpboot: bootservice:<BootServiceURL>

Fixes #

@github-actions github-actions bot added the size/L label Jun 6, 2024
@hardikdr
Copy link
Member Author

hardikdr commented Jun 6, 2024

cc @damyan @5kt

@hardikdr hardikdr requested review from damyan and 5kt June 10, 2024 10:45
damyan
damyan requested changes Jun 17, 2024
View reviewed changes
plugins/httpboot/plugin.go Outdated
ukiURL, err = fetchUKIURL(bootFile6, clientIPs)
if err != nil {
log.Errorf("failed to fetch UKI URL: %v", err)
return resp, true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

plugins/httpboot/plugin.go Outdated
clientIPs, err := extractClientIP6(req)
if err != nil {
log.Errorf("failed to extract ClientIP, Error: %v Request: %v ", err, req)
return resp, true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to false, so if your plugin fails for whatever reason, the plugin chain will not break (meaning: the next plugin in the configuration will get executed)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed it.

plugins/httpboot/plugin.go Outdated Show resolved Hide resolved
@damyan damyan enabled auto-merge (squash) June 17, 2024 10:45
@damyan damyan merged commit e611122 into main Jun 17, 2024
8 checks passed
@damyan damyan deleted the feat/custom-uki-httpboot branch June 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyan damyan damyan approved these changes

@5kt 5kt 5kt approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardikdr @damyan @5kt