Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply endpoint NPE #193

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix apply endpoint NPE #193

merged 3 commits into from
Sep 27, 2024

Conversation

damyan
Copy link
Contributor

@damyan damyan commented Sep 27, 2024

  • switch to controllerutil.CreateOrPatch() when creating an endpoint to avoid a null pointer exception
  • MAC address casing in the inventory.yaml no longer matters - everything gets serialised lower case to match the handling of IPAM and metal-operator
  • improve some logging along the way

@github-actions github-actions bot added bug Something isn't working size/S labels Sep 27, 2024
@damyan damyan merged commit b525015 into main Sep 27, 2024
8 checks passed
@damyan damyan deleted the fix/apply-endpoint branch September 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants