Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vungle 4.3.37 release #7

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ashinagawa
Copy link

This commit will add custom and adaptive banner support.

});
}

- (void)initializationSuccess {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the structure of the adapter from all other open source adapters

@@ -485,11 +326,6 @@ - (void)loadInterstitialInternal:(NSString *)placementId

LogAdapterApi_Internal(@"placementId = %@", placementId);

// In favor of supporting all of the Mediation modes there is a need to store the Interstitial delegate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not storing the delegate might cause the adapter to fail under some of the Mediation modes

Barda8

This comment was marked as resolved.

@Barda8 Barda8 self-requested a review November 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants