fixed phpstan issues

irontec · Nov 29, 2023 · 5f1b013 · 5f1b013
1 parent 6381ac9
commit 5f1b013
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 832 deletions.
diff --git a/EntityGeneratorBundle/Doctrine/EntityTrait/TraitManipulator.php b/EntityGeneratorBundle/Doctrine/EntityTrait/TraitManipulator.php
@@ -672,7 +672,7 @@ private function getAssociationMappings(ClassMetadata $classMetadata): array
             $classMetadata->associationMappings,
             function ($property) {
                 return in_array(
-                    $property['type'] ?? null,
+                    $property['type'],
                     [
                         ClassMetadata::ONE_TO_MANY,
                         ClassMetadata::MANY_TO_MANY

diff --git a/EntityGeneratorBundle/Doctrine/EntityTrait/TraitRegenerator.php b/EntityGeneratorBundle/Doctrine/EntityTrait/TraitRegenerator.php
@@ -115,7 +115,7 @@ private function getMappedFieldsInEntity(ClassMetadata $classMetadata)
             $classMetadata->associationMappings,
             function ($mapping) {
                 return in_array(
-                    $mapping['type'] ?? null,
+                    $mapping['type'],
                     [
                         ClassMetadata::ONE_TO_ONE,
                         ClassMetadata::ONE_TO_MANY,

diff --git a/EntityGeneratorBundle/Doctrine/Property.php b/EntityGeneratorBundle/Doctrine/Property.php
@@ -4,6 +4,7 @@
 
 class Property implements CodeGeneratorUnitInterface
 {
+    /** @var mixed | null */
     private $defaultValue;
 
     public function __construct(
@@ -130,7 +131,7 @@ public function toString(string $nlLeftPad = ''): string
                             : 'false';
                         break;
                     case 'string':
-                        if (!is_null($this->defaultValue)) {
+                        if (!empty($this->defaultValue)) {
                             $defaultValue = '\'' . $this->defaultValue . '\'';
                         }
                         break;

diff --git a/EntityGeneratorBundle/Doctrine/Repository/RepositoryRegenerator.php b/EntityGeneratorBundle/Doctrine/Repository/RepositoryRegenerator.php
@@ -145,38 +145,6 @@ private function getDoctrineClassTemplate(
         ];
     }
 
-    private function getClassTemplate(
-        ClassMetadata $metadata,
-                      $templateName
-    ): array
-    {
-        [$path, $variables] = $this->generator->generateClassContentVariables(
-            $metadata->name,
-            $templateName,
-            []
-        );
-
-        if (file_exists($variables['relative_path'])) {
-            $variables['relative_path'] = realpath($variables['relative_path']);
-        } else {
-            $variables['relative_path'] = str_replace(
-                'vendor/composer/../../',
-                '',
-                $variables['relative_path']
-            );
-        }
-
-
-        return [
-            $variables['relative_path'],
-            $this->fileManager->parseTemplate(
-                $path,
-                $variables
-            )
-        ];
-    }
-
-
     private function createClassManipulator(
         string  $classPath,
         ?string $content