Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use security name for symbol if there is no symbol #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boxydog
Copy link

@boxydog boxydog commented Jan 1, 2025

Addresses #100

@boxydog
Copy link
Author

boxydog commented Jan 1, 2025

Probably this also needs to bump the version number? I wasn't sure. Sometimes maintainers bump it themselves because only they know what order PRs are merged in.

@boxydog
Copy link
Author

boxydog commented Jan 5, 2025

One downside of this approach is that later clients don't know that the data didn't have a stock symbol.

An alternate approach would be to keep "symbol" empty, but have a property like "key" that is used in place of symbol, where "key" is "symbol, or name if symbol is empty". That would preserve the information that a security has no symbol for later use by clients.

Let me know your thoughts.

@isaacharrisholt
Copy link
Owner

This is good, thanks. I'm probably going to wait for #105 to be merged first though - that may have an impact on this and I don't wanna be chasing down bugs.

As for the key approach, it's not part of the spec so I'm not too keen to add it if it's not needed. I think this is fine for now. One potential future improvement to quiffen is the concept of strict vs lenient modes. I'll open an issue to remind myself.

@isaacharrisholt isaacharrisholt linked an issue Jan 7, 2025 that may be closed by this pull request
@isaacharrisholt
Copy link
Owner

Worth rebasing this one and re-running the tests since the UV changes

@boxydog
Copy link
Author

boxydog commented Jan 27, 2025

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security without symbol causes an error
2 participants