feat: Implement LSP-compliant glob pattern matching with caching #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom glob matching implementation with official gopls glob
pattern matcher to provide full LSP 3.17 specification compliance.
The implementation includes:
- LSP-compliant glob pattern syntax support:
* * : match one or more characters in a path segment
* ? : match one character in a path segment
* ** : match any number of path segments, including none
* {} : OR expressions for alternation (e.g., **/*.{ts,js})
* [] : character ranges (e.g., [a-z])
* [!...] : negated character ranges (e.g., [!0-9])
- Thread-safe pattern caching with safety valve:
* Uses sync.Map for efficient, lock-free reads
* Clears cache if size exceeds 100 entries to protect against
unbounded growth from pattern leaks
* Logs warning when cache is cleared
Implementation is derived from golang.org/x/tools/gopls/internal/lsp/glob
with proper attribution to The Go Authors.
Fixes file watcher pattern matching for complex glob patterns that were
previously unsupported, improving compatibility with LSP clients and
language servers.
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace custom glob matching implementation with the official gopls glob pattern matcher to provide full LSP 3.17 specification compliance. This fixes file watcher pattern matching for complex glob patterns that were previously unsupported.
Changes
Integrate LSP-compliant glob pattern matcher from golang.org/x/tools/gopls
Support all LSP glob pattern syntax:
*- match one or more characters in a path segment?- match one character in a path segment**- match any number of path segments, including none{}- OR expressions (e.g.,**/*.{ts,js})[]- character ranges (e.g.,[a-z])[!...]- negated character ranges (e.g.,[!0-9])Implement thread-safe pattern caching with safety valve:
sync.Mapfor efficient, lock-free readsRemove previous go-gitignore-based implementation and custom brace expansion
Implementation Details
The implementation is derived from
golang.org/x/tools/gopls/internal/lsp/globwith proper attribution to The Go Authors. Pattern caching eliminates redundant parsing on every file system event, significantly reducing CPU usage during high-frequency file watching operations.