Improved page loading #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike findSingleResult, the getContentById method uses the cache in GitContentManager. This should speed up loading commonly-accessed pages.
Same as 33e71c1 but for general pages.
Same as 33e71c1 but for page fragments.
We now consistently use the cache-based getContentById. The only other difference (beyond this old method lacking caching) is that this errored out if more than one piece of content matched, but I think that's no big loss.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 27.70% 27.69% -0.01%
==========================================
Files 504 504
Lines 22931 22933 +2
Branches 2837 2835 -2
==========================================
Hits 6352 6352
- Misses 15979 15981 +2
Partials 600 600
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
We removed the type this corresponded to in 72cb910
mlt47
reviewed
Jul 13, 2023
mlt47
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these methods used question attempts, and locally there is not much difference between the speed of the old method and the new one. Sometimes it could be 75% faster, sometimes the same time; it was never worse which is good enough for me. I expect better results on the server (where the cache is helpful and other things are happening in the API).
We now consistently used
getContentByIdfor loading pages and fragments of all kinds, and sofindSingleResultcan and has been removed. The code is easier to read since all the methods are very similar to one another. A later improvement might be to reduce the code duplication.