Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop MailJet from erroring when there are no emails to send #556

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

mlt47
Copy link
Contributor

@mlt47 mlt47 commented Aug 21, 2023


Pull Request Check List

  • Unit Tests & Regression Tests Added (Optional)
  • Removed Unnecessary Logs/System.Outs/Comments/TODOs
  • Added enough Logging to monitor expected behaviour change
  • Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
  • Security - Data Exposure - PII is not stored or sent unencrypted
  • Security - Data Exposure - Test any altered or created endpoints using swagger
  • Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
  • Peer-Reviewed

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.11% 🎉

Comparison is base (990e552) 27.80% compared to head (21eb833) 27.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   27.80%   27.92%   +0.11%     
==========================================
  Files         504      504              
  Lines       22949    22954       +5     
  Branches     2842     2844       +2     
==========================================
+ Hits         6382     6410      +28     
+ Misses      15961    15932      -29     
- Partials      606      612       +6     
Files Changed Coverage Δ
.../ac/cam/cl/dtg/segue/comm/MailGunEmailManager.java 49.29% <33.33%> (+38.68%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsharkey13 jsharkey13 merged commit 8ee8b32 into master Aug 22, 2023
3 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/allow-mailjet-batch-to-not-send-emails branch August 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants