Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES to filter schools so that limit is correct #557

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

mlt47
Copy link
Contributor

@mlt47 mlt47 commented Aug 30, 2023

Undo a temporary commit so that ElasticSearch does the filtering of closed schools meaning that the endpoint's limit query param works correctly.


Pull Request Check List

  • Unit Tests & Regression Tests Added (Optional)
  • Removed Unnecessary Logs/System.Outs/Comments/TODOs
  • Added enough Logging to monitor expected behaviour change
  • Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
  • Security - Data Exposure - PII is not stored or sent unencrypted
  • Security - Data Exposure - Test any altered or created endpoints using swagger
  • Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
  • Peer-Reviewed

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f2b386) 27.92% compared to head (eec5de3) 27.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   27.92%   27.92%           
=======================================
  Files         504      504           
  Lines       22954    22951    -3     
  Branches     2844     2843    -1     
=======================================
  Hits         6410     6410           
+ Misses      15932    15929    -3     
  Partials      612      612           
Files Changed Coverage Δ
...ain/java/uk/ac/cam/cl/dtg/segue/api/Constants.java 81.18% <ø> (ø)
...cam/cl/dtg/segue/dao/schools/SchoolListReader.java 2.38% <0.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsharkey13 jsharkey13 merged commit fc747bd into master Aug 30, 2023
3 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/filter-schools-using-elastic-search branch August 30, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants