Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomise previewed quiz/test choices #558

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

mlt47
Copy link
Contributor

@mlt47 mlt47 commented Sep 1, 2023

This branch adds a method which prepares questions in a test/quiz to be previewed. It is a subset of the tasks that are needed to augmentQuestionsForUser(...). Currently the only task is to randomise choices in Choice questions but, if there are future features that make use of it (such as initialising parametric questions), we should pull out the common code at that point into a separate private method.


Pull Request Check List

  • Unit Tests & Regression Tests Added (Optional)
  • Removed Unnecessary Logs/System.Outs/Comments/TODOs
  • Added enough Logging to monitor expected behaviour change
  • Security - Data Exposure - PII is not stored or sent unencrypted
  • Security - Data Exposure - Test any altered or created endpoints using swagger
  • Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
  • Peer-Reviewed

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (e820e6f) 27.92% compared to head (bd65b2a) 27.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   27.92%   27.98%   +0.05%     
==========================================
  Files         504      504              
  Lines       22951    22955       +4     
  Branches     2843     2843              
==========================================
+ Hits         6410     6424      +14     
+ Misses      15929    15914      -15     
- Partials      612      617       +5     
Files Changed Coverage Δ
...in/java/uk/ac/cam/cl/dtg/isaac/api/QuizFacade.java 43.98% <100.00%> (+0.07%) ⬆️
...cl/dtg/isaac/api/managers/QuizQuestionManager.java 83.33% <100.00%> (+0.38%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsharkey13 jsharkey13 merged commit 6b72d83 into master Sep 5, 2023
3 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/randomise-previewed-quiz-choices branch September 5, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants