Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline question marking for content summaries #630

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jsharkey13
Copy link
Member

We (still) have two different ways of working out whether a question has been answered correctly. This removes some of the duplication, to fix an issue where inline regions were overlooked when marking a question using the content summary way of marking.

The gameboard-based methods had already been updated to include inline regions, but collateQuestionPartIds(...) did not include them in its collation.

We (still) have two different ways of working out whether a question has
been answered correctly. This removes some of the duplication, to fix an
issue where inline regions were overlooked when marking a question using
the content summary way of marking.

The gameboard-based methods had already been updated to include inline
regions, but collateQuestionPartIds(...) did not include them in its
collation.
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.38%. Comparing base (7024a46) to head (378fe94).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   34.40%   34.38%   -0.02%     
==========================================
  Files         514      514              
  Lines       23096    23086      -10     
  Branches     2794     2791       -3     
==========================================
- Hits         7946     7939       -7     
+ Misses      14350    14349       -1     
+ Partials      800      798       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlt47 mlt47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should achieve the same result as the removed code (but also account for inline questions).

@mlt47 mlt47 merged commit 8434530 into master Aug 20, 2024
3 checks passed
@mlt47 mlt47 deleted the hotfix/inline-question-completeness branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants