Support anonymous users in question finder #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly this isUserStaff also throws, on a null value. This can't happen given the if statement, but Java isn't that clever.
However, do not augment results if question statuses are not specified. This makes it possible to use this endpoint for gameboard building without the overhead of loading question attempts.
jsharkey13
commented
Aug 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
- Coverage 34.40% 34.38% -0.03%
==========================================
Files 514 514
Lines 23101 23109 +8
Branches 2792 2795 +3
==========================================
- Hits 7948 7946 -2
- Misses 14355 14361 +6
- Partials 798 802 +4 ☔ View full report in Codecov by Sentry. |
mlt47
approved these changes
Aug 23, 2024
It was neat, but it did make the code much less clear! Having the static attribute is more efficient than recomputing it each time the method is called, though.
mlt47
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly to add support for anonymous users in question finder augmentation and filtering behaviour.
There are some performance optimisations (don't load the user multiple times, avoid filtering if the filter is equivalent "everything"), and one key behavior change (don't augment results if
statusesis not specified, which restores the old behaviour useful for the gameboard builder).