Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows equivalent answers with different "requiresExactMatch" values to have different feedback #635

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Aug 23, 2024

Currently a SYMBOLIC match to an EXACT answer will supersede all later matches to all other logicFormulaChoices (therefore always providing the default feedback).

This change allows for a special case with custom feedback to be given on questions with both "requiresExactMatch": true and "requiresExactMatch": false choices with the same answer.

e.g. Regression Test Page (Part H)

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.38%. Comparing base (ff38e9b) to head (18a64d1).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...cl/dtg/isaac/quiz/IsaacSymbolicLogicValidator.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   34.40%   34.38%   -0.03%     
==========================================
  Files         514      514              
  Lines       23101    23112      +11     
  Branches     2792     2796       +4     
==========================================
- Hits         7948     7946       -2     
- Misses      14355    14364       +9     
- Partials      798      802       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsharkey13 jsharkey13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a lot of test cases, it's hard to be sure this is always fine; but it seems reasonable! Let's try it out!

@jsharkey13 jsharkey13 merged commit 40e4e8e into master Sep 2, 2024
3 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/equivalent-inputs-incorrect branch September 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants