Hide superseded content in QF for non-teachers #636
Conversation
This is a compromise, since the endpoint is also used for the gameboard builder where superseded questions are desired. We may review who sees superseded questions where later.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 34.38% 34.42% +0.03%
==========================================
Files 514 515 +1
Lines 23109 23123 +14
Branches 2795 2797 +2
==========================================
+ Hits 7946 7960 +14
Misses 14361 14361
Partials 802 802 ☔ View full report in Codecov by Sentry. |
| @@ -438,6 +438,9 @@ public final ResultsWrapper<ContentDTO> questionSearch( | |||
| IsaacSearchInstructionBuilder searchInstructionBuilder = new IsaacSearchInstructionBuilder( | |||
| searchProvider, this.showOnlyPublishedContent, this.hideRegressionTestContent, !showNoFilterContent) | |||
There was a problem hiding this comment.
The other similar options e.g. hideRegressionTestContent are passed in as parameters to the constructor, I'd lean towards doing the same for consistency (or change the lot if there's a good reason to).
There was a problem hiding this comment.
Yes, I didn't like the endless boolean constructor params, especially given the builder pattern the rest of the class uses. So I made this one consistent with the builder pattern and it would be nice to remove the rest from the constructor but that didn't seem important enough now.
This is a compromise, since the endpoint is also used for the gameboard builder where superseded questions are desired. We may review who sees superseded questions where later.