Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utm_source parameter to notification emails #649

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jsharkey13
Copy link
Member

It might have been possible to do this in the content template, but this feels more reliable. This will help judge traffic from assignment, test, and group join notification emails

It might have been possible to do this in the content template, but this
feels more reliable. This will help judge traffic from assignment, test,
and group join notification emails
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.16%. Comparing base (63de1a5) to head (4787f9c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...e/scheduler/jobs/ScheduledAssignmentsEmailJob.java 0.00% 2 Missing ⚠️
...heduler/jobs/ScheduledQuizAssignmentsEmailJob.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   34.15%   34.16%   +0.01%     
==========================================
  Files         520      520              
  Lines       23244    23243       -1     
  Branches     2849     2849              
==========================================
+ Hits         7939     7941       +2     
+ Misses      14504    14501       -3     
  Partials      801      801              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd210
Copy link
Contributor

sjd210 commented Oct 14, 2024

LGTM! 👍

@sjd210 sjd210 merged commit fbc0db4 into master Oct 14, 2024
3 checks passed
@sjd210 sjd210 deleted the improvement/utm-source-notifications branch October 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants