Add options for available symbols and coefficient scaling to Chemistry #69
+49
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd210
changed the title
jacbn
reviewed
Oct 14, 2024
jacbn
reviewed
Oct 14, 2024
jacbn
reviewed
Oct 14, 2024
| <Input type="checkbox" | ||
| checked={doc[prop] ?? checkedIfUndefined ?? false} | ||
| disabled={disabled} | ||
| checked={(!disabled && doc[prop]) ?? checkedIfUndefined ?? false} |
There was a problem hiding this comment.
Not sure you need this change. The useEffect should manage it for you!
Suggested change
| checked={(!disabled && doc[prop]) ?? checkedIfUndefined ?? false} | |
| checked={doc[prop] ?? checkedIfUndefined ?? false} |
There was a problem hiding this comment.
All of these changes seem reasonable and I'll add them in 😊. I think I'd been trying various things to stop useEffect from causing a re-render loop, which lead to some redundancies like this.
jacbn
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option for coefficient scaling:
2 H2 + O2 -> 2 H2O===>>>H2 + 1/2 O2 -> H2Oand for disabling certain "available symbols" such as is done with trig functions for Symbolic Maths questions.
State Symbolscontrols(s), (l), (g), (aq)Both of these are unavailable as options for Nuclear Physics questions.
Main PR here.
Dependant primarily on this API PR before it can be merged (but won't actually do anything without the new Chemistry Checker and its changes).