-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for available symbols and coefficient scaling to Chemistry #69
base: main
Are you sure you want to change the base?
Conversation
<Input type="checkbox" | ||
checked={doc[prop] ?? checkedIfUndefined ?? false} | ||
disabled={disabled} | ||
checked={(!disabled && doc[prop]) ?? checkedIfUndefined ?? false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you need this change. The useEffect
should manage it for you!
checked={(!disabled && doc[prop]) ?? checkedIfUndefined ?? false} | |
checked={doc[prop] ?? checkedIfUndefined ?? false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these changes seem reasonable and I'll add them in 😊. I think I'd been trying various things to stop useEffect
from causing a re-render loop, which lead to some redundancies like this.
Adds option for coefficient scaling:
2 H2 + O2 -> 2 H2O
===>>>H2 + 1/2 O2 -> H2O
and for disabling certain "available symbols" such as is done with trig functions for Symbolic Maths questions.
State Symbols
controls(s), (l), (g), (aq)
Both of these are unavailable as options for Nuclear Physics questions.
Main PR here.
Dependant primarily on this API PR before it can be merged (but won't actually do anything without the new Chemistry Checker and its changes).