Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ada landing pages & homepage updates #1189

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Oct 17, 2024

Creates common components, /students and /teachers landing pages, and applies some updates to the Ada homepage.

@mwtrew mwtrew self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 80.83333% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@3c20ac4). Learn more about missing BASE report.
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
src/app/components/pages/TeacherResources.tsx 50.00% 11 Missing ⚠️
src/app/components/pages/StudentResources.tsx 66.66% 5 Missing ⚠️
src/app/components/content/IsaacCard.tsx 55.55% 4 Missing ⚠️
src/app/components/content/IsaacCardDeck.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1189   +/-   ##
=========================================
  Coverage          ?   36.61%           
=========================================
  Files             ?      442           
  Lines             ?    19373           
  Branches          ?     6352           
=========================================
  Hits              ?     7094           
  Misses            ?    11641           
  Partials          ?      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacbn
Copy link
Contributor Author

jacbn commented Oct 17, 2024

Waiting on text for "Further learning" section on Homepage. Content also need to replace pod images with new 16:9 ratio ones made for the new AdaCard component. Otherwise should be ready to go.

</ImageBlock>
<TextBlock>
<h2>Track your progress</h2>
<p>With an Ada account, all your answers get saved so you can see what to work on and how you’re progressing. And you can track any assignments set by your teacher.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logged-in behaviour is missing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants