This repository was archived by the owner on Feb 27, 2022. It is now read-only.
Override cluster size with environment variable.#14
Open
eirikurn wants to merge 1 commit intoisaacs:masterfrom
Open
Override cluster size with environment variable.#14eirikurn wants to merge 1 commit intoisaacs:masterfrom
eirikurn wants to merge 1 commit intoisaacs:masterfrom
Conversation
It's such a common requirement for ops to have the final say over the clustering, that configurability should be built in IMHO. Just like CLUSTER_MASTER_REPL. Size is the most important setting for us, but the same argument might be used for other settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's such a common requirement for ops to have the final say over the clustering, that configurability should be built in IMHO. Just like CLUSTER_MASTER_REPL.
Size is the most important setting for us, but the same argument might be used for other settings.