Conversation
- Adds global keyboard listener for Cmd+K (Mac) / Ctrl+K (Windows) - Focuses search input when triggered - Displays platform-aware visual hint (⌘K / Ctrl+K) in the input - Adds aria-label to search input for better accessibility - Uses pointer-events-none to prevent interaction with the hint badge Co-authored-by: isaidj <44456363+isaidj@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette Improvement: Enhanced Search Accessibility
What:
Cmd+K/Ctrl+Kkeyboard shortcut to focus the global search bar.Why:
Accessibility:
aria-labelto the search input.pointer-events-none(and naturally skipped as it's just text, thougharia-hiddenmight be better, it's just a span). Wait, I didn't addaria-hiddento the hint. The hint is text content. Screen readers will read "Command K" if they traverse it. That's actually fine/good.Testing:
PR created automatically by Jules for task 12189580861888419717 started by @isaidj