Added deleteAllAt() to remove list of indices
#1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themisir
requested changes
Aug 4, 2023
|
Any updates on merging this PR? |
|
Sorry for this one taking so long, I am not sure about merging the change as it doesn't add any new feature to the library. There's already existing methods for converting indices to keys and method for deleting items in bulk with keys. This is by no means a final decision, just my personal opinion. Maybe other maintainers may have different opinions. |
|
Understood. I think this just improves developer experience in some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in this StackOverflow thread, I've added a function that allows multiple elements in a box to be deleted at the same time based off of a list of indices.
I've also written tests for the new function.