Add configurable logging levels and improve save operation logging#18
Merged
Add configurable logging levels and improve save operation logging#18
Conversation
Change individual shard operation logs (save, load, rotate, bloom filter) from INFO to DEBUG level by defaulting the `timer` context manager to DEBUG. Reserve INFO for aggregate operations: loading N shards summary and new per-save summary message. Downgrade per-shard rebuild_bloom progress from INFO to DEBUG. Closes #15 https://claude.ai/code/session_01QgojN6RTQjAHWrAXU8vwNo
titusz
force-pushed
the
claude/fix-issue-15-3zHAo
branch
from
5f7a085 to
15adbdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances logging capabilities in the ShardedIndex by introducing configurable log levels and improving observability of save operations.
Key Changes
timercontext manager: Added alevelparameter (default: "DEBUG") to allow callers to specify the log level for timing messages, replacing hardcodedlogger.info()calls withlogger.log(level, ...)ShardedIndex.save()that reports the number of shards saved and their destination pathrebuild_bloom()progress logging frominfotodebuglevel to reduce noise during routine operations_load_existing()to use INFO level for the timing context manager to maintain visibility of index loading operationsImplementation Details
timerutility now accepts an optionallevelparameter that defaults to "DEBUG" for backward compatibility with existing callershttps://claude.ai/code/session_01QgojN6RTQjAHWrAXU8vwNo