Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning msg if no orbit file found for zip file #46

Merged
merged 2 commits into from
May 27, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented May 27, 2022

  • s1_orbit.get_orbit_file_from_list(): print out warning msg if no orbit file found from the given list (address [Bug]: ET.parse(orbit_path) FileNotFoundError #42)

  • s1_orbit.get_orbit_file_from_dir(): search file in orbit_dir with .EOF extension, instead of arbitrary, to provide more meaningful error msg if given a dir with files but w/o any *.EOF file.

+ s1_orbit.get_orbit_file_from_list(): print out warning msg if no orbit file found from the given list

+ s1_orbit.get_orbit_file_from_dir(): search file in orbit_dir with .EOF extension, instead of arbitrary, to provide more meaningful error msg if given a dir with files but w/o any *.EOF file.
Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/s1reader/s1_orbit.py Outdated Show resolved Hide resolved
Co-authored-by: Liang Yu <liangjyu@gmail.com>
Copy link
Contributor

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yunjunz yunjunz merged commit 2cc4e66 into isce-framework:main May 27, 2022
@yunjunz yunjunz deleted the orbit branch May 27, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants