Merge pull request #34 from isd-sgcu/pet-svc/delete-cascade-img

Pet svc/delete cascade img

src/app/service/image/image.service.go

@@ -167,6 +167,48 @@ func (s *Service) Delete(id string) (*dto.DeleteImageResponse, *dto.ResponseErr)
 	}, nil
 }
 
+func (s *Service) DeleteByPetId(petId string) (*dto.DeleteImageResponse, *dto.ResponseErr) {
+	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+	defer cancel()
+
+	request := &proto.DeleteByPetIdRequest{
+		PetId: petId,
+	}
+
+	res, errRes := s.client.DeleteByPetId(ctx, request)
+	if errRes != nil {
+		st, _ := status.FromError(errRes)
+		log.Error().
+			Err(errRes).
+			Str("service", "image").
+			Str("module", "delete by pet id").
+			Msg(st.Message())
+		switch st.Code() {
+		case codes.NotFound:
+			return nil, &dto.ResponseErr{
+				StatusCode: http.StatusNotFound,
+				Message:    constant.ImageNotFoundMessage,
+				Data:       nil,
+			}
+		case codes.Unavailable:
+			return nil, &dto.ResponseErr{
+				StatusCode: http.StatusServiceUnavailable,
+				Message:    constant.UnavailableServiceMessage,
+				Data:       nil,
+			}
+		default:
+			return nil, &dto.ResponseErr{
+				StatusCode: http.StatusInternalServerError,
+				Message:    constant.InternalErrorMessage,
+				Data:       nil,
+			}
+		}
+	}
+	return &dto.DeleteImageResponse{
+		Success: res.Success,
+	}, nil
+}
+
 func (s *Service) AssignPet(in *dto.AssignPetRequest) (*dto.AssignPetResponse, *dto.ResponseErr) {
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 	defer cancel()

src/app/service/pet/pet.service.go

@@ -253,6 +253,12 @@ func (s *Service) Delete(id string) (result *dto.DeleteResponse, err *dto.Respon
 			}
 		}
 	}
+
+	_, errSvc := s.imageService.DeleteByPetId(id)
+	if errSvc != nil {
+		return nil, errSvc
+	}
+
 	return &dto.DeleteResponse{
 		Success: res.Success,
 	}, nil

src/app/service/pet/pet.service_test.go

@@ -543,19 +543,26 @@ func (t *PetServiceTest) TestUpdateUnavailableServiceError() {
 }
 
 func (t *PetServiceTest) TestDeleteSuccess() {
-	protoReq := &petproto.DeletePetRequest{
+	petProtoReq := &petproto.DeletePetRequest{
 		Id: t.Pet.Id,
 	}
-	protoResp := &petproto.DeletePetResponse{
+	petProtoResp := &petproto.DeletePetResponse{
+		Success: true,
+	}
+	imageProtoReq := &imgproto.DeleteByPetIdRequest{
+		PetId: t.Pet.Id,
+	}
+	imageProtoResp := &imgproto.DeleteByPetIdResponse{
 		Success: true,
 	}
 
 	expected := &dto.DeleteResponse{Success: true}
 
 	client := &petmock.PetClientMock{}
-	client.On("Delete", protoReq).Return(protoResp, nil)
+	client.On("Delete", petProtoReq).Return(petProtoResp, nil)
 
 	imageClient := imagemock.ImageClientMock{}
+	imageClient.On("DeleteByPetId", imageProtoReq).Return(imageProtoResp, nil)
 
 	imageSvc := imageSvc.NewService(&imageClient)
 	svc := NewService(client, imageSvc)

src/pkg/service/image/image.service.go

@@ -9,5 +9,6 @@ type Service interface {
 	FindByPetId(string) ([]*dto.ImageResponse, *dto.ResponseErr)
 	Upload(*dto.UploadImageRequest) (*dto.ImageResponse, *dto.ResponseErr)
 	Delete(string) (*dto.DeleteImageResponse, *dto.ResponseErr)
+	DeleteByPetId(string) (*dto.DeleteImageResponse, *dto.ResponseErr)
 	AssignPet(*dto.AssignPetRequest) (*dto.AssignPetResponse, *dto.ResponseErr)
 }