Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Signup #2

Merged
merged 21 commits into from
Dec 26, 2023
Merged

[Feature] Signup #2

merged 21 commits into from
Dec 26, 2023

Conversation

Nitiwat-owen
Copy link
Member

@Nitiwat-owen Nitiwat-owen commented Dec 25, 2023

  • implement signup service and handler

  • write unit test for signup service and handler

  • introduce gomock for mocking interface

    mockGen:
        mockgen -source ./src/pkg/service/auth/auth.service.go -destination ./src/mocks/service/auth/auth.mock.go
        mockgen -source ./src/pkg/service/user/user.service.go -destination ./src/mocks/service/user/user.mock.go
        mockgen -source ./src/app/validator/validator.go -destination ./src/mocks/validator/validator.mock.go
        mockgen -source ./src/app/router/context.go -destination ./src/mocks/router/context.mock.go
    

Demo

  • Signup successfully:
    Screenshot 2566-12-26 at 12 26 16
    Screenshot 2566-12-26 at 12 26 32

  • Signup failed due to duplicate email:
    Screenshot 2566-12-26 at 12 27 52

Copy link
Contributor

@bookpanda bookpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/app/handler/auth/auth.handler.go Show resolved Hide resolved
src/pkg/service/auth/auth.service.go Show resolved Hide resolved
src/mocks/client/auth/auth.mock.go Show resolved Hide resolved
@bookpanda bookpanda merged commit 236475c into dev Dec 26, 2023
2 checks passed
@bookpanda bookpanda deleted the feature/signup branch December 26, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants