Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOH-26] Sign out #5

Merged
merged 10 commits into from
Jan 4, 2024
Merged

[JOH-26] Sign out #5

merged 10 commits into from
Jan 4, 2024

Conversation

Nitiwat-owen
Copy link
Member

  • implement sign out endpoint

Demo

Firstly, we need to sign in to get access token, then we put the token in the headers of request
Screenshot 2567-01-02 at 23 17 54

Then auth session in database would be deleted.
Screenshot 2567-01-02 at 23 18 34

Copy link

linear bot commented Jan 2, 2024

JOH-26 Auth and User endpoints

Signup - POST /auth/signup

Signin - POST /auth/signin

Signout - POST /auth/signout

Validate - POST /auth/verify

RefreshToken - POST /auth/refreshToken

Copy link
Contributor

@bookpanda bookpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 112 to 115
if err != nil {
st, _ := status.FromError(err)
switch st.Code() {
case codes.Unavailable:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a log here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think so.

@Nitiwat-owen Nitiwat-owen merged commit cec8bf7 into dev Jan 4, 2024
2 checks passed
@bookpanda bookpanda deleted the JOH-26/sign-out branch January 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants