Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOH-84] Image Service's FindAll, DeleteByPetId #10

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[JOH-84] Image Service's FindAll, DeleteByPetId #10

merged 3 commits into from
Feb 14, 2024

Conversation

bookpanda
Copy link
Contributor

@bookpanda bookpanda commented Feb 13, 2024 •
edited
Loading

Change made

  •  New features
  •  Bug fixes
  •  Breaking changes

Describe what you have done

  • Added FindAll and DeleteByPetId in Image service for use in Gateway Pet service

New Features

  • new methods in image repository, service, minio client
  • unit tests

Fix

Others

  • note that the DeleteMany method in minio client could be further optimized with its RemoveMany method using channels, but it'd take a lot of effort restructing.

@linear Linear
Copy link

linear bot commented Feb 13, 2024

JOH-84 Image add FindAll, DeleteByPetId

@bookpanda bookpanda merged commit 74fdfb7 into dev Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macgeargear macgeargear macgeargear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bookpanda @macgeargear