Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add home page ( user-main-2 ) #14

Merged
merged 47 commits into from
Jan 6, 2024
Merged

Conversation

punchanabu
Copy link
Member

@punchanabu punchanabu commented Jan 3, 2024

Feature ( /home )

  • Banner สำหรับใส่โฆษณา / ประชาสัมพันธ์

  • Search และ Filter ( แบบ หมาแมว only )

  • PetHeading and MobilePetHeading ไว้แสดงจำนวนสัตว์ทั้งหมด

  • MiniPetCardContainer ไว้ render mini pet card

  • BigPetCardContainer ไว้ render big pet card

  • แล้วก็เพิ่ม mockPetData ไว้ใน /mock เพื่อจะได้ใช้ ( มั้ง )

  • แล้วก็ตอนแรกไป merge branch คนอื่นมากะจะเอา petcard มาลองใช้ 555

punchanabu and others added 22 commits December 27, 2023 18:14
- It's a template and still need to use props in those components
Current problems:
at "src\components\card\SmallPetCard.tsx"
The <UtcStringToList utcString={birthdate} /> has an error "Type '{ utcString: string; }' is not assignable to type 'string'. It leads to the error that the birthyear and birthmonth of Pets are both "NaN"
Copy link

linear bot commented Jan 3, 2024

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
johnjud-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 4:52am

Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented!

src/components/Divider/DividerMobile.tsx Outdated Show resolved Hide resolved
src/components/Divider/Divider.tsx Outdated Show resolved Hide resolved
src/components/Main/Heading/MobilePetsHeading.tsx Outdated Show resolved Hide resolved
src/components/Main/Heading/PetsHeading.tsx Outdated Show resolved Hide resolved
src/components/Main/SearchFilter/Search.tsx Outdated Show resolved Hide resolved
src/components/Main/SearchFilter/Filter.tsx Outdated Show resolved Hide resolved
@punchanabu
Copy link
Member Author

punchanabu commented Jan 5, 2024

  • Combine Divider.tsx and mobileDivider.tsx in to one component.
  • Use Heading.tsx from /pets and add onSearch props in Heading.tsx which have variable displayText to determined what will be showed
  • Move Search.tsx to /Search folder and change its name to PetSearchGreen.tsx
  • Add a white variant to Button.tsx
  • Refactor Filter.tsx by using Button.tsx component from p'boom

Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented!

src/components/Pets/Heading.tsx Outdated Show resolved Hide resolved
src/components/Search/PetSearchGreen.tsx Outdated Show resolved Hide resolved
src/components/Main/Filter.tsx Outdated Show resolved Hide resolved
Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@punchanabu punchanabu merged commit b948577 into dev Jan 6, 2024
3 checks passed
@punchanabu punchanabu deleted the feature/joh-19-user-main-2 branch January 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants