Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Feature/rkm66 59 be add new field for personality game #5

Merged

Conversation

AKKatung159
Copy link
Member

No description provided.

internal/entity/user/user.model.go Outdated Show resolved Hide resolved
proto/rpkm66/backend/user/v1/user.proto Outdated Show resolved Hide resolved
proto/rpkm66/backend/user/v1/user.proto Outdated Show resolved Hide resolved
Copy link
Member

@ImSoZRious ImSoZRious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you re add the test and don't forget to submit open new pr for chaning proto.

internal/repository/user/user.repository.go Outdated Show resolved Hide resolved
internal/service/user/user.service.go Show resolved Hide resolved
proto/rpkm66/backend/user/v1/user.proto Outdated Show resolved Hide resolved
@ImSoZRious
Copy link
Member

        	Error:      	Not equal: 
        	            	expected: *v1.UpdatePersonalityGameResponse(&v1.UpdatePersonalityGameResponse{state:impl.MessageState{NoUnkeyedLiterals:pragma.NoUnkeyedLiterals{}, DoNotCompare:pragma.DoNotCompare{}, DoNotCopy:pragma.DoNotCopy{}, atomicMessageInfo:(*impl.MessageInfo)(nil)}, sizeCache:0, unknownFields:[]uint8(nil), User:(*v1.User)(0xc000388900)})
        	            	actual  : *v1.UpdateUserResponse(&v1.UpdateUserResponse{state:impl.MessageState{NoUnkeyedLiterals:pragma.NoUnkeyedLiterals{}, DoNotCompare:pragma.DoNotCompare{}, DoNotCopy:pragma.DoNotCopy{}, atomicMessageInfo:(*impl.MessageInfo)(nil)}, sizeCache:0, unknownFields:[]uint8(nil), User:(*v1.User)(0xc000388c00)})

Test failed because you use the wrong method


	eventSrv := &eMock.RepositoryMock{}
	srv := NewService(repo, fileSrv, eventSrv)
	actual, err := srv.Update(context.Background(), t.UpdateUserReqMock)

It's TestUpdatePersonalityGameNotFound. The point is to test method UpdatePersonalityGame, so it should've use srv.UpdatePersonalityGame

@ImSoZRious ImSoZRious force-pushed the feature/rkm66-59-be-add-new-field-for-personality-game branch from 24f6eaf to 12b88fc Compare August 2, 2023 12:44
@ImSoZRious ImSoZRious merged commit 54009de into beta Aug 2, 2023
2 checks passed
@ImSoZRious ImSoZRious deleted the feature/rkm66-59-be-add-new-field-for-personality-game branch August 2, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants