Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My/feat/homepage #26

Merged
merged 13 commits into from
Oct 21, 2024
Merged

My/feat/homepage #26

merged 13 commits into from
Oct 21, 2024

Conversation

amphikapha
Copy link
Contributor

@amphikapha amphikapha commented Oct 11, 2024

Type of Change

  • New features
  • Bug fixes
  • Breaking changes
  • Refactor
  • Documentation updates
  • Other (please specify): edit eslint.config to ignore _

Description

New features:
http://localhost:5173/home naja

Refactor:
I just notice that i misspelled 'AnnouncementCard'

Other:
Since pagination dot for mobile has _ that is defined but never used  @typescript-eslint/no-unused-vars, so i just edit eslint.config to ignore _
ref: typescript-eslint/typescript-eslint#8464

Screenshots or GIFs (if applicable)

localhost-5173-home-google-chrome-2567-10-11-23-06-39_I0sIHYmm.mp4

Copy link
Member

@punchanabu punchanabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job มาก

src/routes/home/+page.svelte Outdated Show resolved Hide resolved
src/routes/home/+page.svelte Outdated Show resolved Hide resolved
src/routes/home/+page.svelte Outdated Show resolved Hide resolved
src/lib/assets/images/sucuHomeBanner1.png Outdated Show resolved Hide resolved
@punchanabu
Copy link
Member

อ่อแล้วก็ฝากเอาหน้านี้มาไว้ใน root path ได้เลยหมายถึงว่าตอนนี้มัน /home เราเอาหน้านี้มาอยู่ / เลย
แล้วก็เอาอันที่มีอยู่ / ตอนนี้ไปอยู่ใน /playground ก็ได้

@amphikapha amphikapha requested a review from punchanabu October 19, 2024 08:26
@amphikapha amphikapha self-assigned this Oct 19, 2024
@amphikapha amphikapha merged commit 0d6feac into dev Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants