Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build 2404 #7176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix build 2404 #7176

wants to merge 2 commits into from

Conversation

daizhirui
Copy link
Contributor

@daizhirui daizhirui commented Feb 22, 2025

Fixed a build issue with Ubuntu 24.04 when cmake is configured with the following arguments:

-DBUILD_SHARED_LIBS=ON
-DUSE_SYSTEM_EIGEN3=ON
-DUSE_SYSTEM_FMT=ON
-DUSE_SYSTEM_GOOGLETEST=ON
-DUSE_SYSTEM_JSONCPP=ON
-DUSE_SYSTEM_NANOFLANN=ON
-DUSE_SYSTEM_PYBIND11=ON
-DUSE_SYSTEM_QHULLCPP=ON
-DGLIBCXX_USE_CXX11_ABI=ON
-DBUILD_EXAMPLES=OFF
-DBUILD_UNIT_TESTS=OFF
-DBUILD_BENCHMARKS=OFF

The compilor complains that std::shared_ptr is not defined in cpp/open3d/visualization/rendering/Renderer.h.
 

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Fixed by including <memory>.

Copy link

update-docs bot commented Feb 22, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant