Skip to content

Fix more issues with CI #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2024
Merged

Fix more issues with CI #84

merged 2 commits into from
May 21, 2024

Conversation

tommyp1ckles
Copy link
Collaborator

@tommyp1ckles tommyp1ckles commented May 13, 2024 •
edited
Loading

  • Replace newlines when tagging resources with test tuple name.
  • Try to remedy leaking AWS resources

@tommyp1ckles
avoid whitespaces in test names for tagging tf resources.
58e15c9 
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles marked this pull request as ready for review May 14, 2024 00:38
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/fix-test-naming branch from acb2389 to da1f8a6 Compare May 14, 2024 01:05
@tommyp1ckles tommyp1ckles changed the title avoid whitespaces in test names for tagging tf resources. Fix more issues with CI May 14, 2024
@tommyp1ckles tommyp1ckles requested a review from PhilipSchmid May 14, 2024 03:15
@tommyp1ckles
fix issue related to elb/nat/nat gw deletion.
46a2fab 
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/fix-test-naming branch from da1f8a6 to 46a2fab Compare May 14, 2024 03:20
@tommyp1ckles tommyp1ckles marked this pull request as draft May 14, 2024 03:33
PhilipSchmid
PhilipSchmid approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tommyp1ckles tommyp1ckles marked this pull request as ready for review May 21, 2024 16:45
@tommyp1ckles tommyp1ckles merged commit 627f4bb into main May 21, 2024
@PhilipSchmid PhilipSchmid deleted the pr/tp/fix-test-naming branch June 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipSchmid PhilipSchmid PhilipSchmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommyp1ckles @PhilipSchmid