Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add reference to Easypanel SCP 1-click install #946

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Supernova3339
Copy link
Contributor

Add a reference to the Easypanel template

What changes does this Pull Request introduce?

This adds a reference to the Easypanel template to make deployment easier for Isso users.

Why is this necessary?

This makes deployment easier, and uses all current configuration values.

@ix5
Copy link
Member

ix5 commented Feb 28, 2023

Hi, thank you for your contribution. Since many people might not be familiar with this easypanel technology, would you mind explaining what it is?

Have you actually verified that the deployment with easypanel works?

In any case, please move this section to either the community or deployment docs section.

@ix5 ix5 added the docs Documentation of the project label Feb 28, 2023
@ix5 ix5 added this to the 0.14 milestone Feb 28, 2023
@Supernova3339
Copy link
Contributor Author

Hi, thank you for your contribution. Since many people might not be familiar with this easypanel technology, would you mind explaining what it is?

Have you actually verified that the deployment with easypanel works?

In any case, please move this section to either the community or deployment docs section.

Hi @ix5 👋

I can confirm it works, as I am the template creator. Easypanel is a docker based solution, which uses FILE mounts to edit isso's configuration. I've included everything there that should be included. If you have any questions, please let me know.

@ix5
Copy link
Member

ix5 commented Feb 28, 2023

Hi @ix5

I can confirm it works, as I am the template creator. Easypanel is a docker based solution, which uses FILE mounts to edit isso's configuration. I've included everything there that should be included. If you have any questions, please let me know.

Then please include that information you just told me in addition to the link in the docs section so that others can also benefit from it.

@Supernova3339
Copy link
Contributor Author

Supernova3339 commented Feb 28, 2023 via email

@ix5
Copy link
Member

ix5 commented Mar 7, 2023

Please add the "explanation" of what easypanel is supposed to be in the same section that you add the link to.

As explained above:

In any case, please move this section [meaning the reference to easypanel] to either the community or deployment docs section.

Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per ix's comment, please move this to the community section.

@ix5
Copy link
Member

ix5 commented Jan 20, 2024

@Supernova3339 please update as requested, closing this otherwise.

@Supernova3339
Copy link
Contributor Author

Supernova3339 commented Jan 20, 2024 via email

@ix5
Copy link
Member

ix5 commented Jan 22, 2024

@Supernova3339 I've updated your PR and moved the reference to Easypanel to the community section of the docs, as has been explained to you numerous times now.

You, @Supernova3339, already know what Easypanel is, but you cannot assume that everyone reading the README of Isso will already be familiar with what Easypanel is. That is why you should at least explain in the docs that it is a "Server Control Panel" that allows "1-click installs".

As for why we asked you to move the reference to the community section: The README should be a brief overview. We cannot add every conceivable link in there, or it'd become cluttered and confusing. That's why the docs are a better place, especially since the community section already links to similar resources that integrate Isso with other systems.

Please try to research a bit more and put yourself in the maintainers' shoes next time, since this has cost me and jelmer unnecessary time over the months. Thank you nonetheless for your contribution and for making the effort to grow the Isso-friendly ecosystem!

Easypanel is a Server Control Panel and they provide an
installer for Isso at https://easypanel.io/docs/templates/isso
@ix5 ix5 merged commit e3ff800 into isso-comments:master Jan 22, 2024
1 check passed
@ix5 ix5 changed the title Add reference to Easypanel docs: Add reference to Easypanel SCP 1-click install Jan 22, 2024
@Supernova3339
Copy link
Contributor Author

Supernova3339 commented Jan 23, 2024 via email

@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants