Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netperf benches #2638

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Netperf benches #2638

merged 8 commits into from
Aug 29, 2023

Conversation

Stevenjin8
Copy link
Contributor

Work for my intern project. Some tools to test network performance using netperf with various mesh configurations. Not where or how to insert this.

@keithmattix

@Stevenjin8 Stevenjin8 requested a review from a team as a code owner August 22, 2023 17:05
@istio-policy-bot
Copy link

😊 Welcome @Stevenjin8! This is either your first contribution to the Istio tools repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 22, 2023
@Stevenjin8
Copy link
Contributor Author

Tests are failing from upstream autopep8 hhatto/autopep8#689. There are several PRs fixing it, but don't seem to be moving forward. Maybe we should pin our version of flake8 to an earlier one? or just use black.

@keithmattix
Copy link
Contributor

I'm no Pythonista, but maybe it makes sense to use the linter that seems more future proof?

@kfaseela
Copy link
Member

wondering how my other PR passed the gencheck, however locally I get the error mentioned here. istio/istio#46518 . Any idea which flake8 version works?

@Stevenjin8
Copy link
Contributor Author

I think the temporary fix is to pin the pycodestyle version to 2.10.0. Relevant issue: hhatto/autopep8#689

@Stevenjin8
Copy link
Contributor Author

wondering how my other PR passed the gencheck, however locally I get the error mentioned here. istio/istio#46518 . Any idea which flake8 version works?

@kfaseela Did your other PRs involve python files? I think it will only lint files that have changed.

@kfaseela
Copy link
Member

wondering how my other PR passed the gencheck, however locally I get the error mentioned here. istio/istio#46518 . Any idea which flake8 version works?

@kfaseela Did your other PRs involve python files? I think it will only lint files that have changed

Then I am.not sure why local run fails when I have not changed any python files

@keithmattix
Copy link
Contributor

@Stevenjin8 The errors I'm seeing from prow now should be fixed with a make gen

@ericvn
Copy link
Contributor

ericvn commented Aug 25, 2023

LGTM. @AndreaM12345 Any thoughts?

Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

ambient-tests/README.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
@istio-testing istio-testing merged commit 1910456 into istio:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants