-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netperf benches #2638
Netperf benches #2638
Conversation
😊 Welcome @Stevenjin8! This is either your first contribution to the Istio tools repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Tests are failing from upstream autopep8 hhatto/autopep8#689. There are several PRs fixing it, but don't seem to be moving forward. Maybe we should pin our version of flake8 to an earlier one? or just use black. |
I'm no Pythonista, but maybe it makes sense to use the linter that seems more future proof? |
wondering how my other PR passed the gencheck, however locally I get the error mentioned here. istio/istio#46518 . Any idea which flake8 version works? |
I think the temporary fix is to pin the pycodestyle version to 2.10.0. Relevant issue: hhatto/autopep8#689 |
@kfaseela Did your other PRs involve python files? I think it will only lint files that have changed. |
Then I am.not sure why local run fails when I have not changed any python files |
@Stevenjin8 The errors I'm seeing from prow now should be fixed with a |
LGTM. @AndreaM12345 Any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Work for my intern project. Some tools to test network performance using netperf with various mesh configurations. Not where or how to insert this.
@keithmattix